Skip to content

DEV: Remove now-redundant is_staff guardian check #33852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DEV: Remove now-redundant is_staff guardian check #33852

wants to merge 1 commit into from

Conversation

Drenmi
Copy link
Contributor

@Drenmi Drenmi commented Jul 25, 2025

What is this change?

The edit_all_post_groups used to have TL4 as the default setting. This update:

  1. Adds in admins and moderators as well as makes those mandatory values.
  2. Gets rid of now-redundant is_staff? check.
  3. Makes use of the magic #edit_all_post_groups_map method.

Test coverage is here:

@Drenmi Drenmi requested a review from martin-brennan July 25, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-brennan martin-brennan Awaiting requested review from martin-brennan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Drenmi