FIX: Process templates before previewing #33848
Conversation
The bare template yaml file provided by the user cannot be directly used for form templates preview, because components such as `TagChooserField` actually rely on a backend process step. This step exists when users actually use the template, but is missing when the admin writes and previews the template. This commit supplements the missing process step, thus fixing the problem that tag-chooser may break ember during admin preview
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/form-templates-preview-broken-with-tag-group/372744/3 |
| fab!(:tag4, :tag) | ||
| fab!(:tag5, :tag) |
There was a problem hiding this comment.
Are these records fabricated to ensure that the tag-chooser selector isn't returning all the tags? Otherwise, we don't need to fabricate these records.
There was a problem hiding this comment.
yeah, so it is using to eq instead of to include
There was a problem hiding this comment.
I thought about it and decided to use them - because I happened to notice a bug in the initial commit, where the processed value would not be written when the attribute was empty.
| @@ -139,7 +140,8 @@ export default class FormTemplateForm extends Component { | |||
| } | |||
|
|
|||
| FormTemplate.validateTemplate(data) | |||
| .then(() => { | |||
| .then(({ form_template }) => { | |||
| this.processedTemplateContent = form_template.template; | |||
There was a problem hiding this comment.
I think there should also be a test for this change. Maybe a system test?
There was a problem hiding this comment.
You are right. Added!
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/daily-summary-9pm-utc/291850/579 |
The bare template yaml file provided by the user cannot be directly used for form templates preview, because components such as
TagChooserFieldactually rely on a backend process step. This step exists when users actually use the template, but is missing when the admin writes and previews the template.This commit supplements the missing process step, thus fixing the problem that tag-chooser may break ember during admin preview