DEV: Prevent edge-cases in the Glimmer post stream #33847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` theme Ensured `.post-stream--cloaked` elements have a `min-height` of `1px` to maintain proper functioning of intersection observers. This change prevents visual issues caused by cloaked items without a fixed height set.
…unctions Wrapped `decorateFn` and `decorateAfterAdopt` calls in `try-catch` blocks to prevent application crashes caused by errors in decorator functions. Logged errors to the console while allowing execution to proceed unless in testing environments, where exceptions are re-thrown.
Set `model` to an empty object if not provided in `decorated-html` component constructor to avoid potential errors caused by undefined or missing `model`.
CvX
approved these changes
Jul 24, 2025
… constructor This was breaking compatibility with the policy plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the DecoratedHtml component by wrapping decorator functions in try/catch blocks. If an error occurs during decoration, it will be surfaced to the console in production but rethrown in test environments, preventing application crashes due to decorator failures.
Additionally, a minimum height is enforced for cloaked posts, preventing edge cases where posts without height wouldn't trigger the intersection observers.