FIX: correctly update last message bus id for threads and channels #33846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given we cache the channels and threads we also store the last message bus id returned by the serializer initially. We need to ensure we update this id when we receive a message otherwise if you leave a channel and come back to it we will load the state from the id stored in the cache initially. threads were doing it but we were not using the correct parameter. This commit will fix multiple bugs, as for example notices that would replay each time you visit channel. We also took this opportunity to clear a notice once you leave a channel even if you didn't click dismiss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given we cache the channels and threads we also store the last message bus id returned by the serializer initially. We need to ensure we update this id when we receive a message otherwise if you leave a channel and come back to it we will load the state from the id stored in the cache initially.
threads were doing it but we were not using the correct parameter.
This commit will fix multiple bugs, as for example notices that would replay each time you visit channel. We also took this opportunity to clear a notice once you leave a channel even if you didn't click dismiss.