FIX: display alert when casting last remaining vote #33845
Merged
+32
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/no-alert-is-displayed-after-casting-last-remaining-vote/373976/3 |
|
any chance we could add a small test here, I guess it is rather tricky to make it. |
I'm not really wanting to develop a test for this, particularly as the change is so small and the test would be tricky, as you mention. |
|
It's ok I added specs, thanks for the contribution @Juanc1to |
jjaffeux
approved these changes
Jul 28, 2025
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/no-alert-is-displayed-after-casting-last-remaining-vote/373976/4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects a slight logic bug that was preventing the alert when the number of remaining votes was zero.