FIX: apply color palette change when preview is unavailable, warn for dark mode #33827
+73
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to 8fea4ea
This fixes an issue where if a live preview wasn't being shown (due to preferences), the color palette wasn't being changed in the theme settings. It's now being applied correctly.
I've also simplified the color-scheme-manager so the logic for handling the default fallback palette is handled in the controller (and determines preview mode in the manager)
This also adds a warning for another case where live previewing isn't available: when the admin is in dark mode.
This will hopefully be temporary while we simplify how dark mode works.