FIX: ensures autogrid works with French spacing #33823
Merged
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
French spacing refers to the extra space that comes before many punctuation marks in French. It's also common in other languages: Italian, Spanish, Catalan, ... Our regexes were only considering the case without space and as a result auto grid would not work in French. This regex based parsing is brittle as proven here, but this commit only focuses on fixing the bug and ensuring this case is tested for future improvements.
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
CvX
approved these changes
Jul 24, 2025
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/daily-summary-9pm-utc/291850/578 |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/daily-summary-5am-utc/291851/550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
French spacing refers to the extra space that comes before many punctuation marks in French.
It's also common in other languages: Italian, Spanish, Catalan, ...
Our regexes were only considering the case without space and as a result auto grid would not work in French.
This regex based parsing is brittle as proven here, but this commit only focuses on fixing the bug and ensuring this case is tested for future improvements.