DEV: Patch ActiveRecord's postgresql adapter .new_client
#33820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates our monkey patch of `ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.new_client` to improve two things: 1. Improve the conditional used to determine if a database does not exist. Just checking that the error message contains the `database` name is not sufficient as the value of the database name may be part of the `host` connection param which can appear in PG error messages as well. 2. When the PG error messages includes the `user` or `host` connection param. We append the original PG error message on to the original error messge so that we don't just end up with a generic error message that doesn't help us to figure out the actual error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates our monkey patch of
ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.new_clienttoimprove two things:
Improve the conditional used to determine if a database does not
exist. Just checking that the error message contains the
databasename is not sufficient as the value of the database name may be part of
the
hostconnection param which can appear in PG error messages aswell.
When the PG error messages includes the
userorhostconnectionparam. We append the original PG error message on to the original
error messge so that we don't just end up with a generic error message
that doesn't help us to figure out the actual error.