Skip to content

DEV: Move tag related guardian tests to tag_guardian_spec #33817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025

Conversation

Drenmi
Copy link
Contributor

@Drenmi Drenmi commented Jul 24, 2025

What is this change?

Preparatory refactoring:

  1. Lift-and-shift the guardian tests relating to TagGuardian into tag_guardian_spec file.
  2. Reorganize the tests a bit so that each top-level describe matches a guardian method.

@Drenmi Drenmi requested a review from martin-brennan July 24, 2025 03:55
@@ -16,7 +16,7 @@ def can_tag_topics?

def can_tag_pms?
return false if !SiteSetting.tagging_enabled
return false if @user.blank?
return false if !authenticated?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More explicit.

@Drenmi Drenmi merged commit 7a5a37f into main Jul 25, 2025
17 checks passed
@Drenmi Drenmi deleted the dev/extract-tag-guardian-tests branch July 25, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants