Skip to content

UX: Notification panel update #33795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 24, 2025
Merged

UX: Notification panel update #33795

merged 9 commits into from
Jul 24, 2025
+66 −58

Conversation

jordanvidrine
Copy link
Contributor

This PR merges the ongoing discourse experiment with notification menu changes into core.

Before After
CleanShot 2025-07-23 at 13 57 32@2x CleanShot 2025-07-23 at 13 55 26@2x
CleanShot 2025-07-23 at 13 57 16@2x CleanShot 2025-07-23 at 13 55 58@2x

@jordanvidrine jordanvidrine force-pushed the notification-panel-update branch from 06c0eee to 5fbcbd2 Compare July 23, 2025 19:08
@gschlager gschlager force-pushed the notification-panel-update branch from 5fbcbd2 to 7789ac2 Compare July 23, 2025 20:01
@awesomerobot
Copy link
Member

Couple minor issues I noticed:

  1. Hover and focus state in the footer makes the icons invisible

    image

  2. keyboard nav focus for tabs is still the old style

    image

@jordanvidrine
init
96eee5d 
non-avatar-menu

done
@jordanvidrine
unify
bc0a88e
@jordanvidrine
Copy link
Contributor Author

Couple minor issues I noticed:

  1. Hover and focus state in the footer makes the icons invisible
    image
  2. keyboard nav focus for tabs is still the old style
    image

these should be fixed now

@jordanvidrine jordanvidrine merged commit d9eefd9 into main Jul 24, 2025
16 checks passed
@jordanvidrine jordanvidrine deleted the notification-panel-update branch July 24, 2025 16:21
@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/new-header-dropdown-notification-menu-styles/369574/1

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/new-header-dropdown-notification-menu-styles/369574/88

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/discourse-design-team-experimentation-topic/285362/1

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/daily-summary-5am-utc/291851/550

CvX added a commit that referenced this pull request Jul 26, 2025
@CvX
UX: Fix tabs in new notification panel
72797a4 
A followup to #33795

1. the hover effect was broken in Safari (becase it was trying to emulate a backround with a box-shadow of a small child element)
2. in <= 400px height viewports elements were overlapping eachother and icons moved on hover
3. changing `--user-menu-border-width` had issues: at 0px and >=3px icons would move on hover, and increasing the value would make tabs overlap with the border
@CvX CvX mentioned this pull request Jul 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sketchius sketchius sketchius approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jordanvidrine @awesomerobot @discoursebot @sketchius @jjaffeux