Skip to content

PERF: reduce embedding concurrent generation #33781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025
Merged

Conversation

SamSaffron
Copy link
Member

Reduce concurrent generation of embeddings
Correct error reporting
Use Discourse ThreadPool

- Reduce concurrent embedding generation from 100 to 30 threads.
- Instead of using leaky CachedThreadPool, use the more predictable Scheduler::ThreadPool
- Report errors on embedding generation problems (once per 5 minutes)
- Correct error reporting for sentiment generation problems
@SamSaffron SamSaffron merged commit b36639f into main Jul 23, 2025
16 checks passed
@SamSaffron SamSaffron deleted the improve_perf_embedding branch July 23, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants