DEV: Capture unhandled JS errors in Playwright logs #33744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

martin-brennan merged 1 commit into main from dev/pageerror-playwright-logs

Jul 22, 2025

Contributor

martin-brennan commented Jul 22, 2025

Before this change, even if we were failing rspec tests due to
JS errors, they were not being shown in the "JS LOGS" backed
by the playwright logger in the failure message. Sometimes the
unhandled JS errors are the cause of the failure, so it
is important to see them.


          DEV: Capture unhandled JS errors in Playwright logs

a0672c0

Before this change, even if we were failing rspec tests due to
JS errors, they were not being shown in the "JS LOGS" backed
by the playwright logger in the failure message. Sometimes the
unhandled JS errors are the _cause_ of the failure, so it
is important to see them.

Drenmi approved these changes

View reviewed changes

Contributor

Drenmi left a comment

🚀

martin-brennan merged commit e81370e into main

16 of 17 checks passed

martin-brennan deleted the dev/pageerror-playwright-logs branch

July 22, 2025 06:14

SamSaffron mentioned this pull request

PERF: switch redis driver to hiredis #33773

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet