DEV: Ensure the collapsed content of quoted posts is decorated #33740
+681
−589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored `blockquote` styles to include `.cooked` class adjustments for consistent padding and margin handling. - Reintroduced conditional support for the `decorateSelectionBarrier` using a computed `shouldAddSelectionBarrier` property. - Improved decorator management and cleanup logic in `decorateBeforeAdopt`.
… handling - Removed `.cooked` class styles under `blockquote`. - Replaced `.cooked` with `.quote-cooked` for improved specificity. - Ensured proper margin adjustments for first and last child elements within `blockquote`.
- Introduced `@className` property in `PostCookedHtml` for flexible class assignment. - Updated `blockquote` styles to replace `.quote-cooked` with `.post__contents-cooked-quote`. - Expanded `Composer Actions` tests to ensure compatibility with `glimmer_post_stream_mode`.
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
CvX
approved these changes
Jul 22, 2025
| @@ -173,7 +173,7 @@ export default class PostQuotedContent extends Component { | |||
| > | |||
| {{#if @wrapperElement}} | |||
| {{! `this.OptionalWrapperComponent` can be empty to render only the children while decorating cooked content. | |||
| we need to handle the attributtes below in the existing wrapper received as @wrapperElement in this case }} | |||
| we need to handle the attributtes below in the existing wrapper received as @wrapperElement in this case }} | |||
There was a problem hiding this comment.
minor: looks like an unintentional indentation change?
Corrected a minor typo in the inline comment for better clarity and accuracy regarding the handling of `@wrapperElement`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
PostCookedHtmlandPostQuotedContentcomponents to enhance how quoted posts are rendered and decorated. It introduces a newclassNameprop for customizing the class of cooked HTML, and ensures collapsed quote content is consistently decorated with appropriate styles and structure.Key changes:
classNameargument toPostCookedHtml, allowing quoted content to have a distinct class for easier styling.PostQuotedContentto render collapsed and expanded quoted content throughPostCookedHtml, ensuring consistent decoration and disabling selection barriers for quoted posts.PostCookedHtmlto conditionally apply selection barriers.