DEV: remove sso_destination_url and use destination_url cookie instead #33736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this cookie was introduced in c28843e about 10 years ago but I couldn't find any reasons why it's any different than the already existing and well-tested destination_url cookie. This commit replaces the use of the 'sso_destination_url' cookie with the generic 'destination_url' cookie, mainly in order to reduce code complexity. This was extracted from #33072
pmusaraj
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this cookie was introduced in c28843e about 10 years ago but I couldn't find any reasons why it's any different than the already existing and well-tested destination_url cookie.
This commit replaces the use of the 'sso_destination_url' cookie with the generic 'destination_url' cookie, mainly in order to reduce code complexity.
This was extracted from #33072