FIX: Don't overwrite translated titles when updating badge #33731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drenmi
commented
Jul 21, 2025
| expect_enqueued_with( | ||
| job: :bulk_user_title_update, | ||
| args: { | ||
| new_title: "Shieldbearer", |
There was a problem hiding this comment.
Sad to change these custom fixtures, but not worth the hassle of injecting custom i18n test strings when we can use existing badges with existing translations. 😢
lis2
approved these changes
Jul 22, 2025
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/trust-level-badge-change-causes-related-title-to-un-translate/342109/4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue?
When using a non-English default locale and editing a badge, the titles for all badge holders using it is reset to the English name.
Why is this happening?
Badge#namewhich is the English name, instead ofBadge#display_namewhich is the localized name.