DEV: Try fix flaky specs from theme site settings #33729
Closed
+34
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19f4cf8 to
b8b4fe8
Compare
We are seeing these flakes a lot, either the theme site setting values don't exist or are the wrong values. Earlier, I didn't see this TestSetup class which runs before each test, so let's try resetting the settings and the cache before each test to make sure things are clean.
b8b4fe8 to
e9dc2c6
Compare
Disable other specs for now too
8168216 to
6ad71ca
Compare
|
This PR may potentially fix things...we will see: |
|
Closing in favor of #33745 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing these flakes a lot, either the theme site setting
values don't exist or are the wrong values. Earlier, I didn't
see this TestSetup class which runs before each test, so let's
try resetting the settings and the cache before each test to make
sure things are clean.