FIX: Show bulk removal of expired invites #33716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
approved these changes
Jul 21, 2025
nattsw
reviewed
Jul 21, 2025
Comment on lines
+13
to
+20
| sign_in(admin) | ||
| end | ||
|
|
||
| describe "expired invites" do | ||
| let(:user_invite_expired_page) { PageObjects::Pages::UserInvitedExpired.new } | ||
| it "correctly shows expired invites" do | ||
| user_invite_expired_page.visit(user) | ||
| expect(user_invite_expired_page.invites_list.size).to eq(invites_expired.size) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An existing codepath to bulk delete invites exists, but does not show up. This commit fixes it and also fixes the old code's bug.
Specifically,
destroy_all_expiredendpoint only acts on thecurrent_userwhich is absolutely counter-intuitive, when a person visits another person’s profile and is able to see the button, clicking it would delete their own invites and not those of the profile they are visiting.UserInvitedShowControllerthe removedAll state is never set to the original state, which results in the link being displayed in the list when the new link expires, but the batch deletion cannot be displayed unless the page is refreshed. It is replaced by a toast.Screenshots