DEV: Add validator for enable_discourse_id setting
#33710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still an internal beta feature, but without an id and a secret, the authenticator shouldn't be enabled.
a027d2e to
6b47bfa
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation for the enable_discourse_id setting to ensure that the Discourse ID authenticator cannot be enabled without proper credentials configured. The validator checks that both discourse_id_client_id and discourse_id_client_secret are present when attempting to enable the feature.
- Adds a new validator class
EnableDiscourseIdValidatorthat prevents enabling Discourse ID without credentials - Updates site settings configuration to use the new validator
- Adds localized error message for missing credentials
- Updates test setup order to configure credentials before enabling the feature
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/validators/enable_discourse_id_validator.rb | New validator class that checks for required credentials before allowing enable_discourse_id to be set to true |
| config/site_settings.yml | Associates the new validator with the enable_discourse_id setting |
| config/locales/server.en.yml | Adds error message for missing Discourse ID credentials |
| spec/lib/validators/enable_discourse_id_validator_spec.rb | Comprehensive test coverage for the new validator |
| spec/system/discourse_id_spec.rb | Updates test setup order to configure credentials before enabling |
| spec/services/discourse_id/revoke_spec.rb | Updates test setup order to configure credentials before enabling |
| spec/requests/discourse_id_controller_spec.rb | Updates test setup order to configure credentials before enabling |
| spec/lib/auth/discourse_id_authenticator_spec.rb | Updates test setup order to configure credentials before enabling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still an internal beta feature, but without an id and a secret, the authenticator shouldn't be enabled.