FEATURE: Add reusable AdminFilterControls component, apply to plugins and reports #33706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…index and reports
pmusaraj
approved these changes
Jul 24, 2025
| File.join(Rails.root, "plugins", "spoiler-alert", "plugin.rb"), | ||
| ) | ||
|
|
||
| Discourse.stubs(:plugins_sorted_by_name).returns([poll_plugin, spoiler_alert_plugin]) |
There was a problem hiding this comment.
Hmm, interesting. Without stubbing, the system spec would have zero plugins?
There was a problem hiding this comment.
Right, that's the problem I was running into... so I did something similar to what I saw elsewhere:
discourse/spec/lib/discourse_updates_spec.rb
Line 288 in 18de0c3
There was a problem hiding this comment.
Hmm, yeah, I see. I guess we run system specs with essentially LOAD_PLUGINS=0 in core. I understand why we initially did that, but it's an environment that doesn't match production, we never run prod without plugins, especially now that plenty of plugins moved to core.
Anyway, worth a separate discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a reusable filter component for admin areas that includes a text filter and dropdown.
The component accepts an array to filter, an array of searchable property names, and optional dropdown values. An additional option is available if you'd like the default dropdown value to be something other than "all."
It looks like this:
The dropdown is optional, without it:
When there are no matching filters, it provides a reset button:
I'll use this to replace occurrences of similar filters, we've added a couple to the AI plugin.