DEV: Upgrade AvatarFlair to Glimmer, enhance avatar handling #33695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests Rewrote the `AvatarFlair` component using Glimmer, removing legacy `MountWidget` usage. Improved maintainability with helper functions for styles and icon handling. Added integration tests to ensure correct rendering for icon and image flair scenarios.
Introduced the `post-avatar-size` value transformer to allow dynamic size adjustments for the `PostAvatar` component. Updated relevant tests to cover the transformer behavior, ensuring accurate rendering of avatar dimensions based on transformed values.
AvatarFlair component to Glimmer and add testsRemoved fixed size attribute in `PostAvatar` test integration setups and adjusted assertions to match updated avatar URL format.
Replaced fixed avatar URL with a regex pattern in `PostAvatar` test assertion to allow flexibility in URL matching.
CvX
approved these changes
Jul 18, 2025
app/assets/javascripts/discourse/tests/integration/components/post/avatar-test.gjs
Outdated
Show resolved
Hide resolved
app/assets/javascripts/discourse/tests/integration/components/post/avatar-test.gjs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AvatarFlaircomponent from classic to Glimmer, refactoring its implementation and template for improved maintainability and performance.PostAvatarcomponent to use the new value transformer for avatar size."post-avatar-size"value transformer in the transformer registry.AvatarFlairandPostAvatarcomponents, ensuring correct behavior for icon/image rendering, style application, and avatar size/template transformation.