DEV: Only load specific plugin bundles during qunit test #33678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaylorhq
added a commit
to discourse/.github
that referenced
this pull request
Jul 18, 2025
davidtaylorhq
added a commit
to discourse/discourse-templates
that referenced
this pull request
Jul 18, 2025
davidtaylorhq
added a commit
to discourse/.github
that referenced
this pull request
Jul 18, 2025
davidtaylorhq
added a commit
to discourse/discourse-templates
that referenced
this pull request
Jul 18, 2025
davidtaylorhq
commented
Jul 21, 2025
| @@ -60,7 +60,7 @@ document.addEventListener("discourse-init", () => { | |||
| } | |||
|
|
|||
| const isPlugin = name.match(/\/plugins\//); | |||
| const isTheme = name.match(/\/theme-\d+\//); | |||
| const isTheme = name.match(/\/theme--?\d+\//); | |||
There was a problem hiding this comment.
This is to account for the new system themes, which have negative IDs
There was a problem hiding this comment.
Ah nice! Will rebase to be 100% sure there aren't any conflicts with those changes
CvX
approved these changes
Jul 21, 2025
| @@ -60,7 +60,7 @@ document.addEventListener("discourse-init", () => { | |||
| } | |||
|
|
|||
| const isPlugin = name.match(/\/plugins\//); | |||
| const isTheme = name.match(/\/theme-\d+\//); | |||
| const isTheme = name.match(/\/theme--?\d+\//); | |||
| @@ -213,6 +215,16 @@ export default function setupTests(config) { | |||
| QUnit.config.hidepassed = true; | |||
| QUnit.config.testTimeout = 60_000; | |||
|
|
|||
| window.onunhandledrejection = (event) => { | |||
| // reports test boot failures to testem, so the browser doesn't hang forever | |||
There was a problem hiding this comment.
oh, we didn't have that before? 👀
There was a problem hiding this comment.
I think this explains why we sometimes get those CI jobs which hang forever instead of failing cleanly. (e.g. if there's an import of a non-existent module)
| @@ -1,6 +1,9 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class QunitController < ApplicationController | |||
| # Same list maintained in discourse-test-load-dynamic-js.js | |||
| ALWAYS_LOADED_PLUGINS = %w[discourse-local-dates] | |||
There was a problem hiding this comment.
so in the end only d-local-dates is widely needed?
There was a problem hiding this comment.
Yup, and it's the only core plugin with no 'enabled_setting'
8909daa to
8b957e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, running qunit tests for a plugin would load the JS of all installed plugins. This can be problematic because, depending on the plugins installed in the current environment, there can be unexpected interactions between the plugins.
This commit updates our qunit system to check the
tests.requiredPluginslist from the theme/pluginabout.jsonfile, and only loads the listed plugins. This means that the environment is much more consistent across CI and different development environments.Alongside that change, this commit also:
Starts storing the original
about.jsonfor themes in the databaseImproves qunit error handling when the test environment fails to boot (e.g. there's a bad import in a plugin)
Restores plugin CSS in theme qunit tests