DEV: Use themeable site settings for Horizon #33645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the value transformers introduced to Horizon back in discourse/horizon@274e5f7 and 897d341 in favor of the new themeable site settings introduced in 19af83d , as this is what they are for. No migration for existing sites...they will already have ThemeSiteSetting values from a previous migration to ensure site setting values were preserved in theme site settings.
lis2
approved these changes
Jul 22, 2025
Otherwise the old theme settings still show in the UI. Also fix issue with override indicator for theme site settings, we should always return a string version of thesetting + default to the client, it's what it expeccts
95c6026 to
de6075e
Compare
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/introducing-horizon-our-newest-theme/369608/41 |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/daily-summary-5am-utc/291851/550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the value transformers introduced
to Horizon back in discourse/horizon@274e5f7
and 897d341
in favor of the new themeable site settings introduced in
19af83d , as this is what they
are for.
No migration for existing sites...they will already have
ThemeSiteSetting values from a previous migration to ensure
site setting values were preserved in theme site settings.
We do delete the ThemeField storing the Horizon custom theme
setting definition though, otherwise the UI still shows the old settings.