DEV: SetStore backed implementation of requires_set
#33626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6eccf6a to
7ec25bc
Compare
gschlager
reviewed
Jul 22, 2025
7ec25bc to
c1c3ed1
Compare
This change updates requires_set` internals to use our custom set implementations via `Migrations::SetStore`
Change `DiscourseDB#query_result` implementation to yield value for single column query results instead of a single element array
c1c3ed1 to
62971c6
Compare
s3lase
commented
Jul 25, 2025
gschlager
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates
requires_setinternals to use our custom set implementations viaMigrations::SetStore