Skip to content

UX: show My messages count in sidebar #33539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 22, 2025
Merged

UX: show My messages count in sidebar #33539

merged 18 commits into from
Jul 22, 2025
+125 −23

Conversation

yuriyaran
Copy link
Contributor

@yuriyaran yuriyaran commented Jul 9, 2025 •
edited
Loading

Adds an indicator of new messages next to the “My messages” sidebar link.

Based on user preference sidebar_show_count_of_new_items an icon or count is shown.

No differentiation for old and new new views.

@yuriyaran yuriyaran force-pushed the ux/sidebar-show-messages-count branch 3 times, most recently from 6005966 to dacb1a0 Compare July 21, 2025 10:45
yuriyaran
yuriyaran commented Jul 21, 2025
View reviewed changes
@yuriyaran yuriyaran marked this pull request as ready for review July 21, 2025 11:34
yuriyaran added 15 commits July 22, 2025 17:11
@yuriyaran
dev: adds tests for unread messages - take 1
0eff067
@yuriyaran
dev: adds count/indicator to sidebar messages link - take 2
aea8833
@yuriyaran
dev: counts all new/unread messages - take 3
8c006ae
@yuriyaran
dev: adds count to my messages link - take 4
d14cb85
@yuriyaran
dev: moves pm messages tracking up level to discovery routes
a2f31d1 
Before this change app started tracking unread pms on /messages route
@yuriyaran
dev: reverts removal of pmTopicTrackingState.startTracking() for user…
1c4c15a 
… private messages
@yuriyaran
dev: improves sidebar my messages spec
d2e8a50
@yuriyaran
dev: moves pm tracking trigger to a generic discourse route
5af8fa4
@yuriyaran
dev: sets my messages badgeText same for old and new new views
ff70a88
@yuriyaran
fix: track PMs: adds check if logged in user can_send_private_messages
dfee4aa
@yuriyaran
fix: discourse route: adds missing router service
e83ba41
@yuriyaran
dev: transfers pm subscription from service to standalone instance in…
47883d1 
…itializer
@yuriyaran
dev: adds pmTopicTrackingState.startTracking call in subscribe-user-n…
2f921dc 
…otifs
@yuriyaran
dev: removes wrong approach
582496e
@yuriyaran
dev: removes afterModel calls for pmTopicTrackingState.startTracking
ef77e86
@yuriyaran yuriyaran force-pushed the ux/sidebar-show-messages-count branch from 1612859 to ef77e86 Compare July 22, 2025 14:11
yuriyaran
yuriyaran commented Jul 22, 2025
View reviewed changes
@yuriyaran yuriyaran merged commit 037670f into main Jul 22, 2025
15 of 16 checks passed
@yuriyaran yuriyaran deleted the ux/sidebar-show-messages-count branch July 22, 2025 18:48
@yuriyaran yuriyaran mentioned this pull request Jul 22, 2025
Merged
yuriyaran added a commit that referenced this pull request Jul 22, 2025
@yuriyaran
FIX: adds missing router service import (explicit) (#33756)
477b4c2 
Hotfix to explicitly import `router` service.

This is a follow-up change after #33539.
@SamSaffron SamSaffron mentioned this pull request Jul 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaylorhq davidtaylorhq davidtaylorhq approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuriyaran @davidtaylorhq