-
Notifications
You must be signed in to change notification settings - Fork 130
query tags integration #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sreekanth-db
merged 3 commits into
databricks:main
from
sreekanth-db:query-tags-integration
Aug 25, 2025
Merged
query tags integration #663
sreekanth-db
merged 3 commits into
databricks:main
from
sreekanth-db:query-tags-integration
Aug 25, 2025
+39
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivam2680
reviewed
Aug 5, 2025
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
d61e96a to
cf7df8d
Compare
samikshya-db
approved these changes
Aug 22, 2025
Contributor
samikshya-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a minor nit, otherwise LGTM. Thanks for making the change
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
This PR adds Query Tags support to the Python SQL Connector. Query Tags allow users to attach key-value pairs to SQL executions that appear in the
system.query.historytable.Changes Made:
Created Example File (
examples/query_tags_example.py):Enhanced Integration Test (
tests/e2e/test_driver.py):test_ssp_passthrough()to include Query Tags in session configurationEnhanced Unit Tests (
tests/unit/test_session.py):test_configuration_passthrough()test to verify query tags are properly passed through to the thrift backendtest_session_management()to include query tags in session configuration to ensure query tags work correctly in SEA backendImplementation Details:
Added Query Tags Support in SEA flow (
src/databricks/sql/backend/sea/utils/constants.py):"QUERY_TAGS": ""toALLOWED_SESSION_CONF_TO_DEFAULT_VALUES_MAPto enable query tags support in the SEA (Statement Execution API) backend flowUsage example:
How is this tested?
Testing Details:
Unit Tests:
test_configuration_passthrough()- Verifies Query Tags flow in thrift modetest_session_management()- Verifies Query Tags flow in SEA modeE2E Tests:
test_ssp_passthrough()to include Query Tags in both thirft and SEA modesManual Testing:
examples/query_tags_example.pywith real backend connectionRelated Tickets & Documents