added logs for cloud fetch speed #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

shivam2680 merged 3 commits into main from shivam2680/log-cloud-fetch

Jul 28, 2025

Contributor

shivam2680 commented Jul 28, 2025

What type of PR is this?

Refactor
Feature
Bug Fix
Other

Description

Add logs for cloud fetch download speed

How is this tested?

verified logs are printed when log level is set to INFO

Unit tests
E2E Tests
Manually
N/A

Related Tickets & Documents

https://databricks.atlassian.net/browse/XTA-11037
https://docs.google.com/document/d/18LkarFRXs-a-MTOfoqBtzqA2xnRtgfEeHJ0_cr4LISQ/edit?tab=t.0#heading=h.yaapx77xm84v


          added logs for cloud fetch speed

13d13de

shivam2680 self-assigned this

shivam2680 temporarily deployed to azure-prod

July 28, 2025 08:15

— with

GitHub Actions Inactive

github-actions bot commented Jul 28, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

shivam2680 requested a review from jprakash-db

July 28, 2025 08:15

jprakash-db approved these changes

View reviewed changes

Contributor

jprakash-db left a comment

Some minor nits. Overall LGTM

src/databricks/sql/cloudfetch/downloader.py Show resolved Hide resolved

src/databricks/sql/cloudfetch/downloader.py Outdated Show resolved Hide resolved

src/databricks/sql/cloudfetch/downloader.py Outdated Show resolved Hide resolved


          address commnets

4073d47

shivam2680 temporarily deployed to azure-prod

July 28, 2025 11:14

— with

GitHub Actions Inactive

github-actions bot commented Jul 28, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).


          fix unit test

a63fa28

shivam2680 temporarily deployed to azure-prod

July 28, 2025 11:32

— with

GitHub Actions Inactive

github-actions bot commented Jul 28, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

shivam2680 merged commit 59d28b0 into main

22 of 23 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet