Test pr review refactor #40

2bndy5 · 2024-09-05T08:03:44Z

testing cpp-linter/cpp-linter#117

github-actions · 2024-09-05T08:05:22Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 2 file(s) not formatted

src/demo.cpp
src/demo.hpp

clang-tidy reports: 5 concern(s)

src/demo.cpp:9:5: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
    9 | int main()
      | ~~~ ^     
      | auto       -> int
```
src/demo.cpp:11:13: warning: [readability-braces-around-statements]

statement should be inside braces
```
   11 |     for (;;) break;
      |             ^      
      |              {
```
src/demo.cpp:13:5: warning: [cppcoreguidelines-pro-type-vararg]

do not call c-style vararg functions
```
   13 |     printf( "Hello world!\n");
      |     ^
```

src/demo.hpp:10:11: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function

   10 |     void *not_useful(char *str){
      |     ~~~~~~^                    
      |     auto                        -> void *

src/demo.hpp:12:16: warning: [modernize-use-nullptr]

use nullptr

   12 |         return 0;
      |                ^
      |                nullptr

Have any feedback or feature suggestions? Share it here.

outdated suggestion

github-actions

Cpp-linter Review

Click here for the full clang-tidy patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 18d07bf..9e30a45 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -9 +9 @@ size_t dummyFunc(size_t i) { return i; }
-int main()
+auto main() -> int
@@ -11 +11,3 @@ int main()
-    for (;;) break;
+    for (;;) {
+        break;
+    }
diff --git a/src/demo.hpp b/src/demo.hpp
index 2972211..4a96fbd 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -10,4 +10,5 @@ class Dummy {
-    void *not_useful(char *str){
-        useless = str;
-        return 0;
-    }
+        auto not_useful(char* str) -> void*
+        {
+            useless = str;
+            return nullptr;
+        }

Only 4 out of 5 clang-format concerns fit within this pull request's diff.

Click here for the full clang-format patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 18d07bf..0c1db60 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -11 +11,2 @@ int main()
-    for (;;) break;
+    for (;;)
+        break;
@@ -13 +14 @@ int main()
-    printf( "Hello world!\n");
+    printf("Hello world!\n");
@@ -15 +16,2 @@ int main()
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index 2972211..645a50f 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -9,2 +9,3 @@ class Dummy {
-    public:
-    void *not_useful(char *str){
+public:
+    void* not_useful(char* str)
+    {
@@ -16,23 +17 @@ class Dummy {
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-struct LongDiff
-{
+struct LongDiff {

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-09-05T22:45:27Z

src/demo.cpp


 int main()
 {
-    for (;;)
-        break;
+    for (;;) break;


clang-format suggestion

Suggested change

for (;;) break;

for (;;)

break;

clang-tidy diagnostics

statement should be inside braces [readability-braces-around-statements]

Suggested change

for (;;) break;

for (;;) {

break;

}

github-actions · 2024-09-05T22:45:27Z

src/demo.cpp


-    printf("Hello world!\n");
+    printf( "Hello world!\n");


clang-format suggestion

Suggested change

printf( "Hello world!\n");

printf("Hello world!\n");

clang-tidy diagnostic

src/demo.cpp:13:5: warning: [cppcoreguidelines-pro-type-vararg]

do not call c-style vararg functions

13 | printf( "Hello world!\n"); | ^

github-actions · 2024-09-05T22:45:27Z

src/demo.cpp


-    return 0;
-}
+    return 0;}


clang-format suggestion

Suggested change

return 0;}

return 0;

}

github-actions · 2024-09-05T22:45:27Z

src/demo.hpp

    public:
-    void *not_usefull(char *str){
+    void *not_useful(char *str){


clang-format suggestion

Suggested change

public:

void *not_usefull(char *str){

void *not_useful(char *str){

public:

void* not_useful(char* str)

{

github-actions · 2024-09-05T22:45:27Z

src/demo.cpp

@@ -6,12 +6,10 @@
 // using size_t from cstddef
 size_t dummyFunc(size_t i) { return i; }

 int main()


clang-tidy diagnostics

use a trailing return type for this function [modernize-use-trailing-return-type]

Suggested change

int main()

auto main() -> int

github-actions · 2024-09-05T22:45:28Z

src/demo.hpp

+    void *not_useful(char *str){
        useless = str;
        return 0;
    }


clang-tidy diagnostics

use a trailing return type for this function [modernize-use-trailing-return-type]

use nullptr [modernize-use-nullptr]

Suggested change

void *not_useful(char *str){

useless = str;

return 0;

}

auto not_useful(char* str) -> void*

{

useless = str;

return nullptr;

}

outdated suggestion

turn on debugging output test refactor-pr-reviews branch

outdated suggestion

github-actions

Cpp-linter Review

Click here for the full clang-tidy patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 18d07bf..9e30a45 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -9 +9 @@ size_t dummyFunc(size_t i) { return i; }
-int main()
+auto main() -> int
@@ -11 +11,3 @@ int main()
-    for (;;) break;
+    for (;;) {
+        break;
+    }
diff --git a/src/demo.hpp b/src/demo.hpp
index 2972211..4a96fbd 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -10,4 +10,5 @@ class Dummy {
-    void *not_useful(char *str){
-        useless = str;
-        return 0;
-    }
+        auto not_useful(char* str) -> void*
+        {
+            useless = str;
+            return nullptr;
+        }

Click here for the full clang-format patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 18d07bf..0c1db60 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -11 +11,2 @@ int main()
-    for (;;) break;
+    for (;;)
+        break;
@@ -13 +14 @@ int main()
-    printf( "Hello world!\n");
+    printf("Hello world!\n");
@@ -15 +16,2 @@ int main()
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index 2972211..645a50f 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -9,2 +9,3 @@ class Dummy {
-    public:
-    void *not_useful(char *str){
+public:
+    void* not_useful(char* str)
+    {
@@ -16,23 +17 @@ class Dummy {
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-struct LongDiff
-{
+struct LongDiff {

Have any feedback or feature suggestions? Share it here.

This comment was marked as duplicate.

Sign in to view

2bndy5 mentioned this pull request Sep 5, 2024

Refactor creating PR review comments cpp-linter/cpp-linter#117

Merged

This comment was marked as duplicate.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

github-actions bot previously requested changes Sep 5, 2024

View reviewed changes

2bndy5 force-pushed the test-pr-review-refactor branch from 4a861e3 to 4065be2 Compare September 6, 2024 20:58

This comment was marked as duplicate.

Sign in to view

2bndy5 added 5 commits September 6, 2024 14:06

prep for PR test

ff8f259

turn on debugging output test refactor-pr-reviews branch

test w/ --lines-changed-only

e2a3705

test all lines

939d0d5

test only diff lines

af7bd3f

test summary only

19c9a13

2bndy5 force-pushed the test-pr-review-refactor branch from 455910a to 19c9a13 Compare September 6, 2024 21:07

github-actions bot requested changes Sep 6, 2024

View reviewed changes

2bndy5 closed this Sep 12, 2024

2bndy5 deleted the test-pr-review-refactor branch September 12, 2024 20:31

Test pr review refactor #40

Test pr review refactor #40

Uh oh!

Conversation

2bndy5 commented Sep 5, 2024

Uh oh!

github-actions bot commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Cpp-Linter Report ⚠️

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Uh oh!

github-actions bot Sep 5, 2024

Choose a reason for hiding this comment

clang-format suggestion

clang-tidy diagnostics

Uh oh!

github-actions bot Sep 5, 2024

Choose a reason for hiding this comment

clang-format suggestion

clang-tidy diagnostic

Uh oh!

github-actions bot Sep 5, 2024

Choose a reason for hiding this comment

clang-format suggestion

Uh oh!

github-actions bot Sep 5, 2024

Choose a reason for hiding this comment

clang-format suggestion

Uh oh!

github-actions bot Sep 5, 2024

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions bot Sep 5, 2024

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

This comment was marked as duplicate.

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Uh oh!

Uh oh!

github-actions bot commented Sep 5, 2024 •

edited

Loading