Skip to content

fix: skip empty coverage data in CoverageData.update #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aeeeeeep wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −3
Open

fix: skip empty coverage data in CoverageData.update #2104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions coverage/sqldata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,9 +720,23 @@ def update(
self._start_using()
other_data.read()

# Ensure other_data has a properly initialized database
with other_data._connect():
pass
# Check if the coverage data contains any actual measurements
should_skip = False
with other_data._connect() as other_con:
try:
with other_con.execute("SELECT COUNT(*) FROM tracer") as cur:
tracer_count = cur.fetchone()[0]
with other_con.execute("SELECT COUNT(*) FROM arc") as cur:
arc_count = cur.fetchone()[0]
with other_con.execute("SELECT COUNT(*) FROM line_bits") as cur:
line_bits_count = cur.fetchone()[0]
if tracer_count == 0 and arc_count == 0 and line_bits_count == 0:
should_skip = True
except Exception:
should_skip = False
# Only perform update if there's actual coverage data
if should_skip:
return

with self._connect() as con:
assert con.con is not None
Expand Down