Manifest tweak #2001
Open
Manifest tweak #2001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes license metadata by moving the license configuration into pyproject.toml and cleaning up redundant entries in MANIFEST.in.
- Moved license information to pyproject.toml.
- Removed redundant README.md and LICENSE file inclusion from MANIFEST.in.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Added a license entry in the [project] section and specified license-files in [tool.setuptools] to include the LICENSE. |
| MANIFEST.in | Removed redundant inclusion of README.md and LICENSE, as these details are now managed in pyproject.toml. |
Analysis Details0 Issues
Coverage and Duplications
Project ID: confluent-kafka-python |
pranavrth
reviewed
Jul 24, 2025
| @@ -4,6 +4,7 @@ build-backend = "setuptools.build_meta" | |||
|
|
|||
| [project] | |||
| name = "confluent-kafka" | |||
| license = {file = "LICENSE"} | |||
There was a problem hiding this comment.
Hmm that's odd, since that's where it should be according to docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved license to pyproject.toml, and removed redundant README from Manifest as it's already in the toml definition.
See above
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups