feat: serve cached digest if available #462
Open
+428
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MickaelCa
commented
Jul 27, 2025
- Added methods to upload metadata alongside digest files to S3.
- Implemented S3-based digest caching mechanism for improved efficiency.
- Refactored digest storage logic to support both S3 and local storage.
|
⚙️ Preview environment for PR #462 is available at: |
5b757ee to
655c0ba
Compare
acb00ea to
dd6e541
Compare
dd6e541 to
579894d
Compare
ix-56h
requested changes
Jul 28, 2025
Comment on lines
+70
to
+79
| clone_config = query.extract_clone_config() | ||
| commit_sha = await resolve_commit(clone_config, token=token) | ||
| query.commit = commit_sha | ||
|
|
||
| # Generate S3 file path using the resolved commit | ||
| s3_file_path = generate_s3_file_path( | ||
| source=query.url, | ||
| user_name=cast("str", query.user_name), | ||
| repo_name=cast("str", query.repo_name), | ||
| commit=commit_sha, |
There was a problem hiding this comment.
Suggested change
| clone_config = query.extract_clone_config() | |
| commit_sha = await resolve_commit(clone_config, token=token) | |
| query.commit = commit_sha | |
| # Generate S3 file path using the resolved commit | |
| s3_file_path = generate_s3_file_path( | |
| source=query.url, | |
| user_name=cast("str", query.user_name), | |
| repo_name=cast("str", query.repo_name), | |
| commit=commit_sha, | |
| clone_config = query.extract_clone_config() | |
| query.commit = await resolve_commit(clone_config, token=token) | |
| # Generate S3 file path using the resolved commit | |
| s3_file_path = generate_s3_file_path( | |
| source=query.url, | |
| user_name=cast("str", query.user_name), | |
| repo_name=cast("str", query.repo_name), | |
| commit=query.commit, |
| except ClientError as err: | ||
| # Object doesn't exist if we get a 404 error | ||
| error_code = err.response.get("Error", {}).get("Code") | ||
| if error_code == "404": |
There was a problem hiding this comment.
Use fastapi.status.HTTP_404_NOT_FOUND instead of string validation
| except ClientError as err: | ||
| # Object doesn't exist if we get a 404 error | ||
| error_code = err.response.get("Error", {}).get("Code") | ||
| if error_code == "404": |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.