Skip to content

fix: improve empty repository URL error #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: improve empty repository URL error #454

wants to merge 2 commits into from

Conversation

netoverlord
Copy link

Fixes #453

Summary

This PR fixes a bug where a single space (" ") as input_text caused an empty digest response.

  • whitespace-only inputs now raise {"error": "Invalid repository URL: cannot be empty or spaces only."}.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 26, 2025 •
edited
Loading

⚙️ Preview environment was undeployed.

@MickaelCa
Copy link
Member

MickaelCa commented Jul 26, 2025 •
edited
Loading

Hello, and thank you for your PR!

The returned error should be the same as what we have for invalid repository URL so that the front-end can display them properly

url 'https://pr-454.gitingest.coderamp.dev/api/ingest' \
  -X POST \
  -H 'Content-Type: application/json' \
  --data-raw '{"input_text":" ","token":"","max_file_size":"243","pattern_type":"exclude","pattern":""}'
{"detail":[{"type":"value_error","loc":["body","input_text"],"msg":"Value error, input_text cannot be empty","input":" ","ctx":{"error":{}}}]}

curl 'https://pr-454.gitingest.coderamp.dev/api/ingest' \
  -X POST \
  -H 'Content-Type: application/json' \
  --data-raw '{"input_text":"agaga","token":"","max_file_size":"243","pattern_type":"exclude","pattern":""}'
{"error":"Invalid repository URL 'agaga'"}

@netoverlord
Copy link
Author

netoverlord commented Jul 27, 2025 •
edited
Loading

It returns:
{"error": "Invalid repository URL: cannot be empty or spaces only."}
and it works correctly in the frontend

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(bug): one space as input returns empty digest
3 participants
@netoverlord @MickaelCa @ix-56h