fix: fix directory include pattern matching and normalize Windows paths #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipchristiansen
added a commit
that referenced
this pull request
Mar 13, 2025
filipchristiansen
added a commit
that referenced
this pull request
Mar 13, 2025
…ns (#217) Signed-off-by: Filip Christiansen <22807962+filipchristiansen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces improvements to cross-platform path handling and directory inclusion:
Windows Path Normalization
Backslashes are now converted to forward slashes in
_parse_patterns, ensuring consistent pattern matching on Windows, macOS, and Linux.Directory Include Pattern Handling
If the path is a directory, a trailing slash is appended (e.g.,
src/), so that patterns likesrc/*properly match directories.