fix: allow local development hosts in TrustedHostMiddleware #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - Application returned 400 Bad Request errors when accessed through localhost - TrustedHostMiddleware configuration was too restrictive for local development Solution: - Added localhost, 127.0.0.1, and wildcard pattern to allowed_hosts - Maintained existing production domain configurations - Improved developer experience for local testing
ebawen
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Using a .env file for allowed hosts could be a good idea to keep the configuration adaptable and avoid hardcoding URLs in the app. What do you think? @hannesrudolph @cyclotruc
I agree |
|
Me too, that is what I will do |
|
Closing because it's solved in #31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow All Local Development Hosts in TrustedHostMiddleware
Problem
The application was returning 400 Bad Request errors when accessed through localhost or other local development URLs. This was caused by the TrustedHostMiddleware's restrictive allowed_hosts configuration, which only permitted production domains.
Solution
Updated the TrustedHostMiddleware configuration to include all common local development hostnames and a wildcard pattern. The allowed hosts now include:
localhost127.0.0.1*(wildcard for all hosts)This change maintains the security benefits of TrustedHostMiddleware in production while allowing for easier local development.
Changes
allowed_hostslist in TrustedHostMiddleware configurationgitingest.com,*.gitingest.com,gitdigest.dev)Testing
Notes
*) should be removed for production deployments if strict host checking is required