feat(coder-attach): add coder_external_agent resource #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
reviewed
Aug 6, 2025
| func TestExternalAgent(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| t.Run("OK", func(t *testing.T) { |
There was a problem hiding this comment.
Should also have a test that links this resource to a coder_agent.
provider/external_agent.go
Outdated
Comment on lines
23
to
29
| "token": { | ||
| ForceNew: true, | ||
| Required: true, | ||
| Sensitive: true, | ||
| Description: "Set the environment variable `CODER_AGENT_TOKEN` with this token to authenticate an agent.", | ||
| Type: schema.TypeString, | ||
| }, |
There was a problem hiding this comment.
I don't understand linking these based on the token value rather than just the ID value of the agent. It seems like we'd want to be able to configure the auth type on the coder_agent and have that also apply here.
deansheather
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new Terraform resource
coder_external_agentthat allows users to define external agents for use in workspaces. It allows the coder UI and coder/coder to detect and act on external agent presence.This is part of coder/coder#19091