Skip to content

feat: support codex cli #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

feat: support codex cli #281

wants to merge 30 commits into from

Conversation

35C4n0r
Copy link
Contributor

@35C4n0r 35C4n0r commented Aug 1, 2025

Closes #236
/claim #236

Description

https://www.loom.com/share/4a39d1c2e2324cb2b6f90c1ad6893602?sid=d5211d2c-a2cd-41ae-8580-15ac686756f2

Type of Change

  • New module
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/[namespace]/modules/[module-name]
New version: v1.0.0
Breaking change: [ ] Yes [ ] No

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun run fmt)
  • Changes tested locally

Related Issues

@algora-pbc algora-pbc bot mentioned this pull request Aug 1, 2025
6 tasks
@35C4n0r
Copy link
Contributor Author

35C4n0r commented Aug 1, 2025

@matifali PR ready for review

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Aug 1, 2025

coder/coder#19118


## Prerequisites

- You must add the [Coder Login](https://registry.coder.com/modules/coder-login/coder) module to your template
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead use the module inside the module? I know we have the same requirement in other modules too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matifali So, instead of the user adding this, we pre-include it in our module ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Needs to test though how it works.

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Aug 4, 2025

@hugodutka @DevelopmentCats, please review and let me know if this needs any changes :)

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Aug 5, 2025

@hugodutka thanks for the review, committed the suggested changes.

@35C4n0r 35C4n0r requested a review from hugodutka August 5, 2025 17:10
Copy link
Contributor

@hugodutka hugodutka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just some nits. I expect we'll merge after the next review.

35C4n0r and others added 4 commits August 7, 2025 22:07
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
35C4n0r and others added 12 commits August 7, 2025 22:09
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
@35C4n0r 35C4n0r requested review from hugodutka and matifali August 8, 2025 15:54
@35C4n0r
Copy link
Contributor Author

35C4n0r commented Aug 8, 2025

@hugodutka @matifali made the changes.

@hugodutka
Copy link
Contributor

@35C4n0r when I ran the module in my workspace I got the following error:

time=2025-08-08T16:37:35.443Z level=INFO msg="Starting server on port" port=3284
agent exited with error:
    github.com/coder/agentapi/cmd/server.runServer
        /home/runner/work/agentapi/agentapi/cmd/server/server.go:129
  - ========
    error: unexpected argument '--skip-git-repo-check' found       
                                                                   
      tip: to pass '--skip-git-repo-check' as a value, use '-- --sk
    ip-git-repo-check'                                             
                                                                   
    Usage: codex-aarch64-unknown-linux-musl [OPTIONS] [PROMPT]     
           codex-aarch64-unknown-linux-musl [OPTIONS] [PROMPT] <COM
    MAND>                                                          
                                                                   
    For more information, try '--help'.
    ========:
    github.com/coder/agentapi/cmd/server.runServer.func1
        /home/runner/work/agentapi/agentapi/cmd/server/server.go:115
  - non-zero exit code:
    github.com/coder/agentapi/lib/termexec.init
        <autogenerated>:1

Codex has probably been updated since you last tested if fully. Could we add a test to check that codex works end to end, meaning that it starts successfully after installing the latest version?

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Aug 8, 2025

@hugodutka will do so, looks like there have been 9 minor releases since I raised this PR, I developed in 0.10.0 now it 0.19.0

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Aug 8, 2025

@hugodutka how should we handle this, should we give a base minimum to maximum version ? They haven't released a stable/major version yet, and will continue to push breaking changes regularly.

@hugodutka
Copy link
Contributor

I'd just add a test that installs the latest version and checks if it starts. The test will notify us if they push a breaking change later.

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Aug 8, 2025

The test will notify us if they push a breaking change later.

makes sense, the tests fail now

@hugodutka added the test.

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Aug 8, 2025

0_19_0.patch

These are the minimal changes that would be needed to support 0.19.0 (maybe with tuning the prompt for task_reporting a bit), but the TUI have been restructured https://github.com/openai/codex/releases/tag/rust-v0.11.0 since 0.11.0.
We can take this up as a separate issue/PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codex Module
3 participants