Skip to content

feat: jupyter-notebook: preinstall Python packages #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 31, 2025
Merged

feat: jupyter-notebook: preinstall Python packages #263

merged 14 commits into from
Jul 31, 2025

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jul 30, 2025 •
edited
Loading

Description

Preinstall Python packages for Jupyter Notebook projects.

Type of Change

  • New module
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/coder/modules/jupyter-notebook
New version: v1.2.0
Breaking change: [ ] Yes [x] No

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun run fmt)
  • Changes tested locally
module "jupyter-notebook" {
  count    = data.coder_workspace.me.start_count
  source   = "git::https://github.com/coder/registry.git//registry/coder/modules/jupyter-notebook?ref=feat-jupyter-packages"

  agent_id = coder_agent.main.id

  pip_install_extra_packages = "numpy==1.26.4 django"
}

@mtojek mtojek self-assigned this Jul 30, 2025
@matifali matifali marked this pull request as ready for review July 30, 2025 08:50
@matifali matifali marked this pull request as draft July 30, 2025 08:52
@mtojek mtojek marked this pull request as ready for review July 30, 2025 09:44
@mtojek mtojek requested review from matifali and johnstcn July 30, 2025 09:44
matifali
matifali approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Has this been already been tested? I may not find time to test this myself today.

@mtojek
Copy link
Member Author

mtojek commented Jul 30, 2025 •
edited
Loading

Thanks for the quick look, @matifali!

I tested it here -
Here is the workspace: https://dev.coder.com/@mtojek/marcin-1
.. and the relevant template: https://dev.coder.com/templates/coder/mtojek-docker

Screenshot 2025-07-30 at 11 53 03

@mtojek mtojek requested a review from DevelopmentCats July 30, 2025 11:07
@mtojek mtojek enabled auto-merge (squash) July 30, 2025 11:37
@DevelopmentCats
Copy link
Contributor

ill test it now locally in my personal coder instance and then I will give it the final approval and get it merged

DevelopmentCats
DevelopmentCats approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@DevelopmentCats DevelopmentCats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I tested this and it loads them all perfectly as shown in the script I ran in JupyterLab below.

Image

@mtojek mtojek merged commit 29c52b7 into main Jul 31, 2025
4 checks passed
@mtojek mtojek deleted the feat-jupyter-packages branch July 31, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matifali matifali matifali approved these changes

@DevelopmentCats DevelopmentCats DevelopmentCats approved these changes

@johnstcn johnstcn Awaiting requested review from johnstcn

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtojek @DevelopmentCats @matifali