Skip to content

feat: Sourcegraph Amp module #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Harsh9485
Copy link

@Harsh9485 Harsh9485 commented Jul 29, 2025

Closes #238
/claim #238

Description

Video - https://www.loom.com/share/59e80a7fa3e54973bb0318132bc849a7?sid=4900077a-6fdb-4760-978c-9ad2e2daa9d8

Screenshot 2025-08-02 164234

Type of Change

  • New module
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/harsh9485]/modules/sourcegraph_amp
New version: v1.0.0
Breaking change: [ ] Yes [x] No

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun run fmt)
  • Changes tested locally

Related Issues

@algora-pbc algora-pbc bot mentioned this pull request Jul 29, 2025
6 tasks
@Harsh9485
Copy link
Author

This PR is not ready for review because I’m facing an error, which I’ve fully described on Discord. I’d really appreciate it if you could help me solve it.

https://discord.com/channels/747933592273027093/1143265221545316445/1398733269096337478

@matifali matifali requested a review from hugodutka July 29, 2025 10:43
@matifali matifali requested a review from DevelopmentCats July 29, 2025 16:17
@Harsh9485 Harsh9485 changed the title Add Sourcegraph Amp module feat: Sourcegraph Amp module Aug 2, 2025
@Harsh9485
Copy link
Author

@hugodutka @matifali @bpmct @DevelopmentCats
The test suite isn’t ready for review yet, but the Sourcegraph AMP module is working. Do I need to add a system prompt, or is it okay to skip it?

@Harsh9485
Copy link
Author

@hugodutka @matifali @bpmct @DevelopmentCats
The PR is ready for review.

@hugodutka
Copy link
Contributor

hey @Harsh9485, I haven't reviewed the PR yet, but before I do - agentapi does not officially support Sourcegraph AMP yet. It might just work out of the box, but we'd need to add Sourcegraph AMP-specific tests to https://github.com/coder/agentapi before merging this PR. Here's how to add them: coder/agentapi#32 (review)

@Harsh9485
Copy link
Author

we'd need to add Sourcegraph AMP-specific tests

Ah, so you’re saying I should be the one to add the tests? 😅

@Harsh9485
Copy link
Author

Hey @hugodutka,

I reviewed the PR and understood what the tests are meant for. They make sense for Gemini since it has a lot of repetitive text, but in the case of AMP, it uses a simpler design and doesn’t have repetitive text patterns that match the test structure.

@bpmct mentioned modifying coder/agentAPI if needed to support Sourcegraph AMP.
If these tests are really required, I’d be happy to add them.

Screenshot 2025-08-04 211913

@hugodutka
Copy link
Contributor

@Harsh9485 we do need the tests, the sourcegraph-amp agent type in agentapi, and a README update to mention it's supported. It should be a straightforward PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sourcegraph Amp Module
3 participants