-
Notifications
You must be signed in to change notification settings - Fork 43
feat: Sourcegraph Amp module #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR is not ready for review because I’m facing an error, which I’ve fully described on Discord. I’d really appreciate it if you could help me solve it. https://discord.com/channels/747933592273027093/1143265221545316445/1398733269096337478 |
…y into sourcegraph-amp-module
@hugodutka @matifali @bpmct @DevelopmentCats |
@hugodutka @matifali @bpmct @DevelopmentCats |
hey @Harsh9485, I haven't reviewed the PR yet, but before I do - agentapi does not officially support Sourcegraph AMP yet. It might just work out of the box, but we'd need to add Sourcegraph AMP-specific tests to https://github.com/coder/agentapi before merging this PR. Here's how to add them: coder/agentapi#32 (review) |
Ah, so you’re saying I should be the one to add the tests? 😅 |
Hey @hugodutka, I reviewed the PR and understood what the tests are meant for. They make sense for Gemini since it has a lot of repetitive text, but in the case of AMP, it uses a simpler design and doesn’t have repetitive text patterns that match the test structure. @bpmct mentioned modifying coder/agentAPI if needed to support Sourcegraph AMP. ![]() |
@Harsh9485 we do need the tests, the sourcegraph-amp agent type in agentapi, and a README update to mention it's supported. It should be a straightforward PR. |
Closes #238
/claim #238
Description
Video - https://www.loom.com/share/59e80a7fa3e54973bb0318132bc849a7?sid=4900077a-6fdb-4760-978c-9ad2e2daa9d8
Type of Change
Module Information
Path:
registry/harsh9485]/modules/sourcegraph_amp
New version:
v1.0.0
Breaking change: [ ] Yes [x] No
Testing & Validation
bun test
)bun run fmt
)Related Issues