-
Notifications
You must be signed in to change notification settings - Fork 42
feat: add Hetzner Cloud server template and configuration files #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a70dd7c
to
ca222c3
Compare
dacec3a
to
6866f01
Compare
ba8b12c
to
536aca0
Compare
Hi @DevelopmentCats, could you please have a quick look when you have a chance? |
@brymut, can you fix the failing CI? You may need to add an exception to the typos config. https://github.com/coder/registry/actions/runs/16600024993/job/46963017795?pr=254#step:7:41 |
@matifali Failing CI is because of a variable being mistaken for a spelling mistake. Please check again |
@brymut you need to add an exception to this in |
536aca0
to
5ff1c7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I re-ran the CI but its still detecting it as a typo though. You might have to try setting the typo as just hel
ba2771b
to
19e11a4
Compare
Thanks for the feedback, I've tested locally and changing the typo exception to "hel" works. @matifali / @DevelopmentCats could you please re-run the CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions but looks good to me. I will approve after another review.
} | ||
|
||
locals { | ||
username = data.coder_workspace_owner.me.name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
username = data.coder_workspace_owner.me.name | |
username = lower(data.coder_workspace_owner.me.name) |
display_name = "Home Usage" | ||
interval = 600 # every 10 minutes | ||
timeout = 30 # df can take a while on large filesystems | ||
script = "coder stat disk --path /home/${lower(data.coder_workspace_owner.me.name)}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
script = "coder stat disk --path /home/${lower(data.coder_workspace_owner.me.name)}" | |
script = "coder stat disk --path /home/${local.username}" |
data "coder_provisioner" "me" { | ||
} | ||
|
||
provider "coder" { | ||
} | ||
|
||
data "coder_workspace" "me" { | ||
} | ||
|
||
data "coder_workspace_owner" "me" { | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data "coder_provisioner" "me" { | |
} | |
provider "coder" { | |
} | |
data "coder_workspace" "me" { | |
} | |
data "coder_workspace_owner" "me" { | |
} | |
data "coder_provisioner" "me" {} | |
provider "coder" {} | |
data "coder_workspace" "me" {} | |
data "coder_workspace_owner" "me" {} |
} | ||
} | ||
|
||
data "coder_parameter" "hcloud_server_type" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put a link as a comment on where to get these all machine types?
token = var.hcloud_token | ||
} | ||
|
||
data "coder_parameter" "hcloud_location" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. Put a comment and link to docs where a user can see all available regions. Will make it easy to maintain.
> **Note** | ||
> This template is designed to be a starting point! Edit the Terraform to extend the template to support your use case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use GFM style alerts.
display_name: Hetzner Cloud Server | ||
description: Provision Hetzner Cloud servers as Coder workspaces | ||
icon: ../../../../.icons/hetzner.svg | ||
maintainer_github: brymut |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintainer_github: brymut |
@DevelopmentCats can we add a linter to check the front matter? It could be in go linter too. I keep seeing the use of deprecated resources in new submissions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, I had seen it in other templates, didn't notice that it was removed in the Contributor guidelines
19e11a4
to
96c431c
Compare
Applied requested changes @matifali |
Hi @bpmct could you please have a look at this? |
Closes #209
/claim #209
Description
Added template for Hetzner cloud. Video of template setting up a workspace and connecting using VScode
hetzner.mp4
Type of Change
Testing & Validation
bun test
)bun run fmt
)Related Issues
#209