-
Notifications
You must be signed in to change notification settings - Fork 40
feat(tag_release): add script for automatically tagging and releasing modules #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ignore the warning at the beginning of the script, I have fixed the order of the command, but it ultimately did not effect the performance of the script |
…traints that would effect our registry size for pushing in a single line. this also changes the tagging process to use the atomic option to make the tag script an all or nothing success or fail for tagging.
I realized that there was no real reason to loop the git push commands for the tags since the constraints of the command would never really cause us problems like I had assumed originally. This also introduces the atomic option when pushing tags to make the approach an all or nothing success or fail to prevent a partial state if issues arise. |
the only problem I'm thinking we could have is this would pick up previous modules that weren't tagged and pushed in this commit if they were missed previously. This might not actually be a problem though, and might actually guarantee that we never miss any releases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment about reusing code where possible but leave this to you to do in a separate PR.
Ideally we should extract all parsing/logging functions to a separate file and source that where needed.
return 0 | ||
} | ||
|
||
extract_version_from_readme() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have this logic in multiple scripts now. Thoughts on extracting it to a lib.sh
file we can source where needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly this is a much better idea. We do use this code in a lot of places.
Description
This PR introduces a script
.github/scripts/tag_release.sh
which allows the maintainer and other org members to automatically tag and release modules based on the checked out commit id. This script relies on the README's for the updated modules to accurately reflect the version bump to work properly.Type of Change
Testing & Validation
bun test
)bun run fmt
)Reference
Run on this Commit: 9ed5084
Script Output: