Skip to content

chore: fix nil ptr deref on terraform plan data #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 6, 2025
Merged

chore: fix nil ptr deref on terraform plan data #171

merged 3 commits into from
Aug 6, 2025

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Aug 6, 2025

Could hit a deref if the plan was empty.

aslilac
aslilac approved these changes Aug 6, 2025
View reviewed changes
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment about “avoiding a nil deref” seems redundant to me. it’s in a == nil check on a pointer type :p

but looks good!

@Emyrk Emyrk merged commit 04b3064 into main Aug 6, 2025
3 checks passed
@Emyrk Emyrk deleted the stevenmasley/nil_deref branch August 6, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslilac aslilac aslilac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @aslilac