🤖 fix: prevent background process name collisions #1070
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Background processes are stored in a
Map<processId, BackgroundProcess>inBackgroundProcessManager. TheprocessIdwas set directly fromdisplayName, and it's also used to compute the output directory:When a new process is spawned in the background with a display name that was previously used:
outputDiras the old processexit_codefile still exists in that directory (written by shell trap on exit)refreshRunningStatuses()checks the new process, it reads the staleexit_codefile"exited"even though it just startedstatus === "running"→ process doesn't appearAdditionally, the map entry itself gets overwritten, losing tracking of any previous process with that name.
Fix
Append incrementing suffix
(1),(2), etc. when a collision is detected:This ensures each process gets a unique
outputDir, so no staleexit_codefiles interfere.The original
displayNameis preserved separately on theBackgroundProcessobject for UI display - the banner shows clean names like "Dev Server" while the agent receives unique IDs like "Dev Server (1)" to reference specific processes.Generated with
mux