🤖 fix: provider settings subscription race condition #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9dae7f4 to
324aa9c
Compare
The onConfigChanged subscription handler was dropping notifications when no listener was actively waiting for them. This caused provider settings updates to not propagate reliably until window reload. The fix adds a pendingNotification flag to queue notifications that arrive before the iterator enters its waiting state, ensuring all config changes are delivered to subscribers. _Generated with mux_
Verifies that provider settings updates propagate to the UI without requiring a window reload. The test: 1. Opens settings and sets an OpenAI API key 2. Verifies the masked value appears 3. Closes and reopens settings 4. Confirms the key is still shown as set _Generated with mux_
324aa9c to
4e43cb5
Compare
ammario
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
onConfigChangedsubscription handler was dropping notifications when no listener was actively waiting for them. This caused provider settings updates to not propagate reliably until window reload.Root Cause
The async generator pattern in the subscription was:
Bug: If the callback fired before step 2 (before entering wait state), the notification was silently dropped because
resolveNextwas null.Fix
Added a
pendingNotificationflag that queues notifications arriving before the listener enters its waiting state. When the iterator loops, it checks this flag first and yields immediately if a notification is pending.Generated with
mux