🤖 feat: collapse consecutive bash_output calls in UI #1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
981710a to
10b2257
Compare
Groups 3+ consecutive bash_output tool calls to the same process_id: - Shows first call with 'start' indicator - Shows collapsed indicator with squiggly line and count - Shows last call with 'end' indicator This reduces visual clutter when agents poll background processes repeatedly, while preserving access to first and last output.
- Replace groupConsecutiveBashOutput() with computeBashOutputGroupInfo() - Compute grouping inline during render loop instead of array transformation - Skip middle items (return null) and render collapsed indicator after first - Simplify MessageRenderer to use DisplayedMessage (no synthetic types) - Update tests for new function signature This fixes the issue where grouped items rendered as generic tool calls instead of BashOutputToolCall components.
20ea716 to
9833dbe
Compare
The type guard for bash_output validates against the Zod schema which requires timeout_secs. The mock was missing this field, causing the type guard to fail and fall back to GenericToolCall.
Add debug logging to trace bash_output grouping (temporary)
- Add isExpanded and onToggle props to BashOutputCollapsedIndicator - Track expanded groups in AIView state (keyed by first message ID) - Add firstIndex to BashOutputGroupInfo for reliable group identification - Middle items are shown when group is expanded, hidden when collapsed - Indicator shows 'Show/Hide X more output checks' with visual feedback
The full-width button caused the tooltip to appear in the middle of the chat view. Now the button is inline-flex and the tooltip is removed since the text already indicates the action (Show/Hide).
Member
|
Will leave this as a maybe depending on bash spam behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groups 3+ consecutive
bash_outputtool calls to the sameprocess_idin the UI:This reduces visual clutter when agents poll background processes repeatedly, while preserving access to first and last output.
Changes
groupConsecutiveBashOutput()function inmessageUtils.tsto transform message arraysBashOutputCollapsedIndicatorcomponent with squiggly line SVGBashOutputToolCallto show group position (start/end)AIView.tsxmessage pipelineGenerated with
mux