-
Notifications
You must be signed in to change notification settings - Fork 1
Comparing changes
Open a pull request
base repository: coder/coder-jetbrains-toolbox
base: 0ad31dd
head repository: coder/coder-jetbrains-toolbox
compare: 2decf9b
- 8 commits
- 10 files changed
- 1 contributor
Commits on Jul 28, 2025
-
impl: relax json syntax rules for deserialization
For some clients, workspace polling fails due to the following error: ``` com.squareup.moshi.JsonEncodingException: Use JsonReader.setLenient(true) to accept malformed JSON at path $ ``` I haven’t been able to reproduce this issue, even using the same version deployed at the client (2.20.2). This change is an attempt to relax the JSON parsing rules by enabling lenient mode, in the hope that it will resolve the issue on the client side.
Configuration menu - View commit details
-
Copy full SHA for 4f1c279 - Browse repository at this point
Copy the full SHA 4f1c279View commit details
Commits on Jul 31, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 50da220 - Browse repository at this point
Copy the full SHA 50da220View commit details -
impl: add error logging for malformed JSON responses in Coder REST AP…
…I calls Wraps Moshi converter to log raw response body when JSON parsing fails. It helps debug malformed JSON during workspace polling by logging full response content, content type, and error details when a exception during marshalling occurs. A couple of approaches were tried, unfortunately by the time the exception is raised the response body has already been consumed by Moshi's converter, so you can't read it again. The interceptors are also not really a viable option, they are called before the converters which means: - we don't know if the response body is in the correct form or not. This is problematic because it means for every rest call we have to read the body twice (interceptor and by moshi converter) - we also have to save the intercepted body and store it until we have an exception from moshi, in which case it will have to be logged. This approach only logs on conversion failures, and the only performance impact on successful responses is the fact that we convert the response body byte stream to a string representation that can later be printed, and then again back to a byte stream by the moshi converter.
Configuration menu - View commit details
-
Copy full SHA for 7d4a8ad - Browse repository at this point
Copy the full SHA 7d4a8adView commit details
Commits on Aug 5, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 8fca449 - Browse repository at this point
Copy the full SHA 8fca449View commit details -
impl: configure the rest api client log level from the Settings page
This commit adds support for allowing the user to configure the rest api client log level in the Settings page.
Configuration menu - View commit details
-
Copy full SHA for f8606a0 - Browse repository at this point
Copy the full SHA f8606a0View commit details -
impl: log the rest api client request and response
A new interceptor is now available in the rest client that is able to log different level of details regarding the request/response: - if None is configured by user we skip logging - Basic level prints the method + url + response code - Headers prints in addition the request and response headers sanitized first - Body also prints the request/response body
Configuration menu - View commit details
-
Copy full SHA for 4cab216 - Browse repository at this point
Copy the full SHA 4cab216View commit details -
chore: remove support for lenient moshi marshaller
It is dangerous because it can allow dangerous operations in the plugin due to insufficient data that can be interpreted as default state.
Configuration menu - View commit details
-
Copy full SHA for 8a3a698 - Browse repository at this point
Copy the full SHA 8a3a698View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2decf9b - Browse repository at this point
Copy the full SHA 2decf9bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0ad31dd...2decf9b