chore: set minimum coder server version to v2.24.3 #215
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 4, 2025
deansheather
approved these changes
Aug 4, 2025
60f8964 to
acf0aeb
Compare
29b1d77 to
8f34725
Compare
acf0aeb to
f3468db
Compare
8f34725 to
732f055
Compare
732f055 to
18604cd
Compare
2794fe6 to
f404c56
Compare
a28b21c to
3a4e672
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the minimum required Coder server version from v2.24.2 to v2.25.0 to support VPN daemon functionality on macOS CLI. The change is necessary because the vpn-daemon command is only available in Coder server v2.25.0 and later versions.
- Updates minimum Coder version requirement from v2.24.2 to v2.25.0
- Adds VPNLib framework dependency to the project configuration
- Updates test to dynamically reference the minimum version constant
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Coder-Desktop/project.yml | Adds VPNLib framework as a non-embedded dependency |
| Coder-Desktop/VPNLib/Validate.swift | Updates minimum Coder version constant from "2.24.2" to "2.25.0" |
| Coder-Desktop/Coder-DesktopTests/LoginFormTests.swift | Updates test to use dynamic version reference instead of hardcoded value |
3a4e672 to
8edcc5a
Compare
f404c56 to
0d77ec3
Compare
0d77ec3 to
4ba6ca3
Compare
8edcc5a to
6d8c03a
Compare
6d8c03a to
c7bd12a
Compare
c7bd12a to
4352ef6
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requirement is introduced by #210, as the
vpn-daemoncommand on the macOS CLI isn't present on prior versions.(2.24.3 isn't out yet, but when it does come out, it'll be compatible. 2.25 is out, and it's compatible)