Skip to content

fix: add code signing requirements to xpc connections #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: ethan/networking-in-launchdaemon
Choose a base branch
from
Open

fix: add code signing requirements to xpc connections #206

wants to merge 1 commit into from
+132 −124

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Jul 24, 2025 •
edited
Loading

Continues to address #201.

I've manually tested that this change prevents binaries not signed by the Coder Apple development team from connecting to the Helper over XPC.

Most of the PR diff is me moving the validator out of Download.swift and into Validate.swift

@ethanndickson ethanndickson mentioned this pull request Jul 24, 2025
Open
@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented Jul 24, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jul 24, 2025
Open
Open
@ethanndickson ethanndickson self-assigned this Jul 24, 2025
@ethanndickson ethanndickson force-pushed the ethan/networking-in-launchdaemon branch from c7dbde8 to ef8832a Compare July 28, 2025 07:50
@ethanndickson ethanndickson force-pushed the ethan/xpc-validation branch from ea87f52 to 5bf788f Compare July 28, 2025 07:50
@ethanndickson ethanndickson mentioned this pull request Jul 28, 2025
Closed
@ethanndickson ethanndickson force-pushed the ethan/xpc-validation branch from 5bf788f to 547fd97 Compare July 30, 2025 09:31
@ethanndickson ethanndickson force-pushed the ethan/networking-in-launchdaemon branch from ef8832a to e32d7de Compare July 30, 2025 09:31
@ethanndickson ethanndickson mentioned this pull request Jul 30, 2025
Open
@ethanndickson ethanndickson marked this pull request as ready for review July 30, 2025 13:11
deansheather
deansheather approved these changes Jul 30, 2025
View reviewed changes
@ethanndickson ethanndickson force-pushed the ethan/xpc-validation branch from 547fd97 to 6687411 Compare July 31, 2025 03:57
@ethanndickson ethanndickson force-pushed the ethan/networking-in-launchdaemon branch from eebf562 to 291e5a1 Compare July 31, 2025 07:26
@ethanndickson ethanndickson force-pushed the ethan/xpc-validation branch from 6687411 to ef370db Compare July 31, 2025 07:26
@ethanndickson ethanndickson mentioned this pull request Jul 31, 2025
Open
@ethanndickson ethanndickson force-pushed the ethan/networking-in-launchdaemon branch from 291e5a1 to b0c196f Compare August 4, 2025 02:59
@ethanndickson ethanndickson force-pushed the ethan/networking-in-launchdaemon branch from b0c196f to b81afc9 Compare August 4, 2025 03:00
@ethanndickson ethanndickson force-pushed the ethan/networking-in-launchdaemon branch from b81afc9 to e96075e Compare August 4, 2025 03:03
@ethanndickson ethanndickson force-pushed the ethan/xpc-validation branch 2 times, most recently from be347a8 to e6a3578 Compare August 4, 2025 07:58
@ethanndickson ethanndickson force-pushed the ethan/networking-in-launchdaemon branch 2 times, most recently from a4b58e5 to bd905ae Compare August 4, 2025 08:05
@ethanndickson ethanndickson force-pushed the ethan/networking-in-launchdaemon branch from bd905ae to 33931d6 Compare August 4, 2025 08:07
@ethanndickson ethanndickson mentioned this pull request Aug 4, 2025
Open
@ethanndickson ethanndickson force-pushed the ethan/networking-in-launchdaemon branch from 33931d6 to 0999089 Compare August 4, 2025 09:42
@ethanndickson ethanndickson mentioned this pull request Aug 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanndickson @deansheather