chore: make helper launchdaemon approval mandatory #205
+121
−248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 24, 2025
1737580 to
16c716d
Compare
This was referenced Jul 28, 2025
21a8db1 to
f4ebbbf
Compare
ethanndickson
commented
Aug 4, 2025
| @@ -206,6 +206,3 @@ echo "$signature" >"$PKG_PATH.sig" | |||
|
|
|||
| # Add dsym to build artifacts | |||
| (cd "$ARCHIVE_PATH/dSYMs" && zip -9 -r --symlinks "$DSYM_ZIPPED_PATH" ./*) | |||
|
|
|||
| # Add zipped app to build artifacts | |||
| zip -9 -r --symlinks "$APP_ZIPPED_PATH" "$BUILT_APP_PATH" | |||
There was a problem hiding this comment.
We can no longer distribute the app outside of a pkg (i.e. a zip), as the pkg is responsible for installing the LaunchDaemon.
f4ebbbf to
04dd34b
Compare
deansheather
approved these changes
Aug 4, 2025
1e9fe08 to
b535a7d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR transitions the helper LaunchDaemon from optional UI-based approval to mandatory installation via the .pkg installer. This eliminates the previous SMAppService approach in favor of a traditional LaunchDaemon setup that doesn't require user interaction.
Key changes:
- Adds automatic LaunchDaemon installation during package install/postinstall phases
- Implements development-time helper management with conditional admin privilege prompts
- Removes UI components and services related to optional helper approval
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/upsert-dev-helper.sh | New script for installing/updating helper daemon during local development |
| scripts/update-cask.sh | Adds helper process to uninstall quit list |
| scripts/build.sh | Removes zipped app artifact generation |
| pkgbuild/scripts/preinstall | Adds helper daemon shutdown before installation |
| pkgbuild/scripts/postinstall | Adds helper daemon installation and startup |
| Coder-Desktop/project.yml | Adds post-build script for development helper management |
| Coder-Desktop/Coder-DesktopHelper/com.coder.Coder-Desktop.Helper.plist | Changes from BundleProgram to absolute Program path |
| Coder-Desktop/Coder-Desktop/Views/VPN/VPNState.swift | Refactors UI components into reusable view modifiers |
| Coder-Desktop/Coder-Desktop/Views/Settings/Settings.swift | Removes experimental settings tab |
| Coder-Desktop/Coder-Desktop/Views/Settings/HelperSection.swift | Removes helper management UI components |
| Coder-Desktop/Coder-Desktop/Views/Settings/ExperimentalTab.swift | Removes experimental settings tab |
| Coder-Desktop/Coder-Desktop/HelperService.swift | Removes helper service management code |
| Coder-Desktop/Coder-Desktop/Coder_DesktopApp.swift | Removes helper service dependencies |
b535a7d to
493701d
Compare
Merge activity
|
493701d to
6135453
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in addressing #201.
This PR installs and kickstarts the LaunchDaemon as part of the
.pkginstaller, instead of requiring it be approved via the UI. As such, we no longer distribute the app contained within a.zip.This PR adds a build script to install the LaunchDaemon when developing locally, to ensure it stays up to date when changes are made. Installing the LaunchDaemon requires administrator privileges, so to minimise password prompts, we only restart it when the binary itself, or any of it's frameworks have changed.
There's an Apple Developer Forum thread where I replied, enquiring about this installer approach vs the existing SMAppService approach, esp. w.r.t deploying the app via MDM: https://developer.apple.com/forums/thread/766351?answerId=850675022&page=1#851913022
(This PR previously had UI changes, and I did some refactoring. That refactoring is still in the diff.)