chore: improve the setup experience with various fixes #8130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing logs to be emitted immediately after initial setup, which seemed odd for the user.
- This view can be seen after the user creates their first workspace, so saying first is bad. - It should describe what a workspace is, so I modified the description. - The create from template button wasn't helpful!
- This didn't describe what a template actually is. - The title had the same problem as workspaces, where first makes no sense.
This was causing an exception to be thrown.
| label: t("suspendMenuItem") as | ||
| | string | ||
| | JSX.Element | ||
| | null, |
| label: t("activateMenuItem") as | ||
| | string | ||
| | JSX.Element | ||
| | null, |
BrunoQuaresma
approved these changes
Jun 21, 2023
bpmct
approved these changes
Jun 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every commit message has detailed info of each change. I simply went through the setup experience and noticed ~10 things that were pretty janky.