Skip to content

fix: Fix test flake based on same update time #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Emyrk merged 1 commit into from
Jun 17, 2022
Merged

fix: Fix test flake based on same update time #2484

Emyrk merged 1 commit into from
Jun 17, 2022

Conversation

@Emyrk
Copy link
Member

@Emyrk Emyrk commented Jun 17, 2022

Would be nice to somehow mock the clock, but in lieu of that, 5ms shouldn't kill us...

Fail logs on windows: https://github.com/coder/coder/runs/6941697979?check_suite_focus=true

2022-06-17T19:35:15.8288444Z === Failed
2022-06-17T19:35:15.8288771Z === FAIL: coderd TestPatchTemplateMeta/Modified (0.03s)
2022-06-17T19:35:15.8289561Z     t.go:81: 2022-06-17 19:32:21.754 [DEBUG]	<github.com\coder\coder\coderd\coderd.go:384>	debugLogRequest.func1.1	POST /api/v2/users/first
2022-06-17T19:35:15.8290486Z     t.go:81: 2022-06-17 19:32:21.754 [DEBUG]	<github.com\coder\coder\coderd\coderd.go:384>	debugLogRequest.func1.1	POST /api/v2/users/login
2022-06-17T19:35:15.8291284Z     t.go:81: 2022-06-17 19:32:21.754 [DEBUG]	<github.com\coder\coder\coderd\coderd.go:384>	debugLogRequest.func1.1	POST /api/v2/files
2022-06-17T19:35:15.8292351Z     t.go:81: 2022-06-17 19:32:21.755 [DEBUG]	<github.com\coder\coder\coderd\coderd.go:384>	debugLogRequest.func1.1	POST /api/v2/organizations/f12aef77-524c-4f6c-874a-064db00db801/templateversions
2022-06-17T19:35:15.8293460Z     t.go:81: 2022-06-17 19:32:21.756 [DEBUG]	<github.com\coder\coder\coderd\coderd.go:384>	debugLogRequest.func1.1	POST /api/v2/organizations/f12aef77-524c-4f6c-874a-064db00db801/templates
2022-06-17T19:35:15.8294486Z     t.go:81: 2022-06-17 19:32:21.757 [DEBUG]	<github.com\coder\coder\coderd\coderd.go:384>	debugLogRequest.func1.1	PATCH /api/v2/templates/994b8fd7-7240-42de-803c-20ee3e9309be
2022-06-17T19:35:15.8294967Z     templates_test.go:171: 
2022-06-17T19:35:15.8295405Z         	Error Trace:	templates_test.go:171
2022-06-17T19:35:15.8296234Z         	Error:      	"2022-06-17 19:32:21.7577165 +0000 UTC" is not greater than "2022-06-17 19:32:21.7577165 +0000 UTC"
2022-06-17T19:35:15.8296740Z         	Test:       	TestPatchTemplateMeta/Modified
2022-06-17T19:35:15.8297612Z     t.go:81: 2022-06-17 19:32:21.757 [DEBUG]	<github.com\coder\coder\coderd\coderd.go:384>	debugLogRequest.func1.1	GET /api/v2/templates/994b8fd7-7240-42de-803c-20ee3e9309be
2022-06-17T19:35:15.8298091Z     templates_test.go:179: 
2022-06-17T19:35:15.8298507Z         	Error Trace:	templates_test.go:179
2022-06-17T19:35:15.8299307Z         	Error:      	"2022-06-17 19:32:21.7577165 +0000 UTC" is not greater than "2022-06-17 19:32:21.7577165 +0000 UTC"
2022-06-17T19:35:15.8299809Z         	Test:       	TestPatchTemplateMeta/Modified
2022-06-17T19:35:15.8300330Z     --- FAIL: TestPatchTemplateMeta/Modified (0.03s)
2022-06-17T19:35:15.8300530Z 
2022-06-17T19:35:15.8300708Z === FAIL: coderd TestPatchTemplateMeta (0.00s)

johnstcn
johnstcn approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏰

@Emyrk Emyrk merged commit edd1083 into main Jun 17, 2022
@Emyrk Emyrk deleted the stevenmasley/update_at_flake branch June 17, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Emyrk @johnstcn