feat: Show help tooltip on hover #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

BrunoQuaresma merged 3 commits into main from bq/tooltip-on-hover

Jun 17, 2022

Contributor

BrunoQuaresma commented Jun 16, 2022

Closes #2148

BrunoQuaresma added 2 commits

June 16, 2022 17:20


          feat: Show help tooltip on hover

cc04a08


          Merge branch 'main' of github.com:coder/coder into bq/tooltip-on-hover

98327e5

BrunoQuaresma requested a review from a team as a code owner

June 16, 2022 17:23

BrunoQuaresma self-assigned this

Kira-Pilot approved these changes

View reviewed changes

Contributor

presleyp commented Jun 16, 2022

I'm having trouble running v2 right now, but I checked the storybook, and I saw two weird things:

backticks around an apostrophe in the tooltip text
the tooltip shows up slightly lower in the Open story than it does when I just hover in the Closed story


          Fix apostrophe

4c9a73e

Contributor Author

BrunoQuaresma commented Jun 17, 2022

@presleyp thanks for noticing that.

Fixed
I'm not able to reproduce the "lower" thing. Maybe what is happening is: that since it is open by default you have to enter again and leave to see the action happening.

BrunoQuaresma enabled auto-merge (squash)

June 17, 2022 12:42

BrunoQuaresma merged commit d0aca86 into main

BrunoQuaresma deleted the bq/tooltip-on-hover branch

June 17, 2022 12:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet